Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ffi/SDL2: crash with SDL_FULLSCREEN #900

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 22, 2019

Only actively used on device ports (Ubuntu Touch, Sailfish), so it was silently broken.

Cf. koreader/koreader#4960 and #899

---------------------------------------------
                launching...
  _  _____  ____                _
 | |/ / _ \|  _ \ ___  __ _  __| | ___ _ __
 | ' / | | | |_) / _ \/ _` |/ _` |/ _ \ '__|
 | . \ |_| |  _ <  __/ (_| | (_| |  __/ |
 |_|\_\___/|_| \_\___|\__,_|\__,_|\___|_|

 It's a scroll... It's a codex... It's KOReader!

 [*] Current time: 04/22/19-16:54:43
 [*] Version: v2019.03-129-g5c95597f_2019-04-22

ffi.load: SDL2
ffi.load: SDL2
ffi.load: blitbuffer
ffi.load (assisted searchpath): ./libs/libblitbuffer.so
./luajit: ./ffi/SDL2_0.lua:80: undeclared or implicit tag 'SDL_DisplayMode'
stack traceback:
	[C]: in function 'new'
	./ffi/SDL2_0.lua:80: in function 'open'
	./ffi/framebuffer_SDL2_0.lua:13: in function 'init'
	./ffi/framebuffer.lua:70: in function 'new'
	frontend/device/sdl/device.lua:72: in function 'init'
	frontend/device.lua:49: in main chunk
	[C]: in function 'require'
	./reader.lua:55: in main chunk
	[C]: at 0x5585698dc771
~/src/kobo/koreader

Only actively used on device ports (Ubuntu Touch, Sailfish), so it was silently broken.

Cf. koreader/koreader#4960 and koreader#899
@Frenzie Frenzie added the bug label Apr 22, 2019
@Frenzie Frenzie merged commit 5be7118 into koreader:master Apr 22, 2019
@Frenzie Frenzie deleted the fix-sdl2-fullscreen branch April 22, 2019 14:55
Frenzie added a commit to Frenzie/koreader that referenced this pull request Apr 22, 2019
* [fix] ffi/SDL2: crash with `SDL_FULLSCREEN` koreader/koreader-base#900
* simplify framebuffer dpi handling koreader/koreader-base#843
Frenzie added a commit to koreader/koreader that referenced this pull request Apr 22, 2019
* [fix] ffi/SDL2: crash with `SDL_FULLSCREEN` koreader/koreader-base#900
* simplify framebuffer dpi handling koreader/koreader-base#843
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant