Skip to content

Commit

Permalink
Remove unused code for proHeading, fix custom class for proScrollToTo…
Browse files Browse the repository at this point in the history
…pButton
  • Loading branch information
Janis K committed Mar 17, 2019
1 parent e080bfa commit 9d48d45
Show file tree
Hide file tree
Showing 6 changed files with 9,946 additions and 32 deletions.
27 changes: 0 additions & 27 deletions elements/proHeading/proHeading/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@ import vcCake from 'vc-cake'
const vcvAPI = vcCake.getService('api')

export default class ProHeadingElement extends vcvAPI.elementComponent {
validateSize (value) {
let units = [ 'px', 'em', 'rem', '%', 'vw', 'vh' ]
let re = new RegExp('^-?\\d*(\\.\\d{0,9})?(' + units.join('|') + ')?$')
if (value === '' || value.match(re)) {
return value
} else {
return null
}
}

render () {
let { id, atts, editor } = this.props
let { text, elementTag, font, devicesSettings, alignment, lineHeight, letterSpacing, link, colorType, customClass, metaCustomId } = atts
Expand Down Expand Up @@ -48,23 +38,6 @@ export default class ProHeadingElement extends vcvAPI.elementComponent {
classes += ' ' + customClass
}

if (lineHeight) {
lineHeight = this.validateSize(lineHeight)

if (lineHeight) {
innerCustomProps.style.lineHeight = lineHeight
}
}

if (letterSpacing) {
letterSpacing = this.validateSize(letterSpacing)

if (letterSpacing) {
letterSpacing = /^\d+$/.test(letterSpacing) ? letterSpacing + 'px' : letterSpacing
innerCustomProps.style.letterSpacing = letterSpacing
}
}

let mixinData = this.getMixinData('textColor')

if (mixinData) {
Expand Down
270 changes: 269 additions & 1 deletion elements/proHeading/public/dist/element.bundle.js

Large diffs are not rendered by default.

4,787 changes: 4,786 additions & 1 deletion elements/proHeading/public/dist/vendor.bundle.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default class ProScrollToTopButton extends vcvAPI.elementComponent {
let customProps = {}

if (customClass) {
containerClasses =+ ` ${customClass}`
containerClasses += ` ${customClass}`
}

if (metaCustomId) {
Expand Down
105 changes: 104 additions & 1 deletion elements/proScrollToTopButton/public/dist/element.bundle.js

Large diffs are not rendered by default.

4,787 changes: 4,786 additions & 1 deletion elements/proScrollToTopButton/public/dist/vendor.bundle.js

Large diffs are not rendered by default.

0 comments on commit 9d48d45

Please sign in to comment.