Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Савельев Григорий #171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Савельев Григорий #171

wants to merge 6 commits into from

Conversation

luvairo-m
Copy link

elybelyaev
elybelyaev reviewed Feb 5, 2024
View reviewed changes
TagsCloud.Tests/TextAnalyzerTests.cs Outdated
group.WordInfo.IsRussian.Should().Be(isEnglish);
}

private static IEnumerable<(WordTagGroup Group, bool isRussian)> GetTestGroups()

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

TagsCloud.Tests/CloudOptionsBuilderTests.cs Outdated

[TestFixture]
[TestOf(nameof(CloudOptionsBuilder))]
public class CloudOptionsBuilderTests

This comment was marked as resolved.

Sign in to view

TagsCloud/Processors/InputProcessor.cs Outdated

private Result<HashSet<WordTagGroup>> ExtractGroupsFromFile(string filename, IFileReader reader)
{
try

This comment was marked as resolved.

Sign in to view

TagsCloud/Processors/OutputProcessor.cs Outdated

public Result<HashSet<WordTagGroup>> SaveVisualization(HashSet<WordTagGroup> wordGroups, string filename)
{
try

This comment was marked as resolved.

Sign in to view

TagsCloud/TextAnalysisTools/TextAnalyzer.cs Outdated
{
public static Result<HashSet<WordTagGroup>> FillWithAnalysis(HashSet<WordTagGroup> wordGroups)
{
try

This comment was marked as resolved.

Sign in to view

TagsCloud/Extensions/ResultExtensions.cs
return new Result<T>(error);
}

public static Result<T> Of<T>(Func<T> func, string error = null)

This comment was marked as resolved.

Sign in to view

TagsCloud/Contracts/ICloudProcessor.cs Outdated
using TagsCloud.Results;
using TagsCloudVisualization;

namespace TagsCloud.Contracts;

This comment was marked as resolved.

Sign in to view

@luvairo-m
Применение TestCaseSource + TestCaseData к тестам TextAnalyzer'a.
a73f72c 
Перемещение интерфейсов из общей папки в папки реализаций.
@luvairo-m
Переработка TextAnalyzer: удаление try catch { } и добавление Result-…
091b5e1 
…логики.
@luvairo-m
Добавление валидатора путей в проект.
ec04d5b 
Расширение обработки ошибок работы с файлами и директориями.
Небольшие правки в тестах.
@luvairo-m
Добавление интеграционного теста.
ade4e0b 
Расширение тестов OptionsBuilder'ов положительными сценариями.
Небольшие правки в TagsCloud.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elybelyaev elybelyaev elybelyaev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luvairo-m @elybelyaev