Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement improvements in Vault and VC Issuance contracts #156

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Implement improvements in Vault and VC Issuance contracts #156

merged 8 commits into from
Dec 5, 2023

Conversation

juanmagiraldor
Copy link
Contributor

@juanmagiraldor juanmagiraldor commented Dec 4, 2023 •
edited
Loading

Description

Fixes #157

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my change

@juanmagiraldor juanmagiraldor force-pushed the implement-vault-changes-in-contract branch from 1fd4382 to 6bf82ba Compare December 4, 2023 20:14
@juanmagiraldor juanmagiraldor changed the title Improve vault Implement improvements in vault and VC Dec 4, 2023
@juanmagiraldor juanmagiraldor force-pushed the implement-vault-changes-in-contract branch from 6bf82ba to e01f5e3 Compare December 4, 2023 21:14
@juanmagiraldor juanmagiraldor self-assigned this Dec 4, 2023
@juanmagiraldor juanmagiraldor force-pushed the implement-vault-changes-in-contract branch from e01f5e3 to 6a7046c Compare December 4, 2023 21:17
@miguelnietoa miguelnietoa changed the base branch from v0.12 to v0.13 December 5, 2023 15:46
@miguelnietoa miguelnietoa changed the base branch from v0.13 to v0.12 December 5, 2023 15:51
@miguelnietoa miguelnietoa changed the base branch from v0.12 to v0.13 December 5, 2023 15:51
@miguelnietoa miguelnietoa changed the title Implement improvements in vault and VC Implement improvements in Vault and VC Issuance contracts Dec 5, 2023
@miguelnietoa miguelnietoa merged commit b542f69 into kommitters:v0.13 Dec 5, 2023
1 check passed
juanmagiraldor added a commit to juanmagiraldor/chaincerts-smart-contracts that referenced this pull request Dec 6, 2023
@juanmagiraldor @miguelnietoa
Implement improvements in Vault and VC Issuance contracts (kommitters…
74b5fb4 
…#156)

* Implement vault improvements

* Implement vc changes

* Refactor code

Co-authored-by: Juan Manuel Giraldo <[email protected]>

* Fix soroban-sdk version

* Adjust multi-contract structure

* Adjust CI and CD

* Update did_contract submodule

* Fix date format

---------

Co-authored-by: Miguel Nieto <[email protected]>
Co-authored-by: Juan Manuel Giraldo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees

@juanmagiraldor juanmagiraldor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanmagiraldor @miguelnietoa