Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for CCE and HIP compilers for interoperability #62

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

srinathv
Copy link

In the process for using CCE 15.0.1 and Rocm 5.4.3, it was necessary to shield new ifdef variables.

@crtrott
Copy link
Member

crtrott commented Apr 20, 2023

Hi,

thanks for the change, we don't have a super active maintainer right now for this. Anyway: if you wanted to check for Kokkos Version we could get rid of the ifdefs altogether and just Kokkos::SharedSpace, but its only available in Kokkos 4.0. In Kokkos 4.0 HIP is also not experimental there (for backward compatibility we do have aliases in the Experimental namespace for now). Thoughts?

@cferenba
Copy link

@crtrott thanks for the feedback. I believe this is a change we made on our side working from kokkos develop before the full 4.0 was available. So there might be a better way to handle this using Kokkos::SharedSpace. We'll look into it.

@crtrott
Copy link
Member

crtrott commented Apr 20, 2023

Again it depends. If you are still stuck on Kokkos 3.7 I think this is fine (and it will work with 4.0 and likely 4.1). But if you are anyway keeping up-to-date and we don't need 3.7 support we can update this to use SharedSpace.

@cferenba
Copy link

Right now we're using 4.0 on RZVernal and 3.7 on the other platforms we support. We'll move to all 4.0 in the future but still working on the timeline for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants