Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to show episode durations #18

Open
wants to merge 6 commits into
base: add-various-features
Choose a base branch
from

Conversation

jose1711
Copy link
Contributor

No description provided.

@kapitan-iglu
Copy link
Contributor

Zdar,
informacia o dlzke videa nebola v minulosti dostupna. Zda sa, ze medzi casom pribudla. Suhlasim s tym aby sa zobrazovala aj v addone.

Mam vsak par pripomienok:

  1. Porovnal som subory medzi aktualnou vetvou master a tvojim forkom duration a su tam zmeny, ktore uz boli mergnute davnejsie. Zaroven sa mi zda, ze si vychadzal z vyvojovej (a momentalne zaostalej) vetvy add-various-features. Niesom github guru, neviem co to spravi pri mergeovani, ale istejsi by som bol, keby si upravy robil na forku z aktualneho stavu...
  2. ...a zvysil aj verziu a pridal zapis do changelogu ak sa to ma aj zverejnit ;)
  3. Skusal si dlzku videa vlozit do nato urcenej vlastnosti (infoLabel) 'duration' v xbmcgui.ListItem? Vid. setInfo(). Ocakaval by som, ze sa potom dlzka videa zobrazi na standardnom mieste (podla skinu) a nebude treba ju explicitne vkladat pred nazov videa. Vdaka tomu by:
    • nebolo nutne mat dalsiu moznost v nastaveniach (dlzka sa bude zobrazovat vzdy)
    • mozno zacne fungovat aj vstavane triedenie podla dlzky, atp...
  4. Ked uz pridavat dalsie vlastnosti, tak preco nepridat aj datum publikovania videa 'published' do infolabelu 'dateadded'? ;)

Neskusis spravit novy fork (z aktualneho mastra) a don zapracovat body 2. 3. a 4.?

@kapitan-iglu kapitan-iglu self-assigned this Feb 4, 2018
@jose1711
Copy link
Contributor Author

uz je to nejaky piatok, co som sa v tom hrabal ale myslim, ze problem s infoLabel bol v tom, ze epizody nie su videoItem objekty, ale directoryItem, ktore tieto atributy nemaju. aplikovat na aktualnu stable vetvu mozem, ale prerabat celu logiku sa mi nechce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants