-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade eslint to v9.10.0 #191
Open
iambumblehead
wants to merge
14
commits into
koajs:master
Choose a base branch
from
iambumblehead:upgrade-to-eslint9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: upgrade path-to-regex to v8.1.0 * chore: upgrade path-to-regex to v8.1.0 * chore: clean up test syntax * chore: clean up whitespace changes * chore: use String constructor instead of .toString for type conversion
This reverts commit 0b184f9.
3imed-jaberi
force-pushed
the
master
branch
3 times, most recently
from
September 17, 2024 23:50
26805e9
to
057c50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello, this PR updates eslint to version 9.10.0 so npm install no longer shows red audit warning messages.
xo
is removed because it does not support eslint 9 Upgrade to ESLint 9 xojs/xo#757,eslint-config-xo-lass
exports an eslint 8 config, however its "rules" are usable with eslint 9 here,unicorn
is added as adependency, because some of its eslint rules are used byeslint-config-xo-lass
,npm run lint
fails because of the lint errors --no effort is made to resolve this,npm run lint
fails, the husky commit hook failsHopefully this PR will be useful so that project owners may apply any remaining changes in ways they prefer.
Thank you :)
Checklist