Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle newfound lint errors #1142

Merged
merged 1 commit into from
Sep 11, 2023
Merged

handle newfound lint errors #1142

merged 1 commit into from
Sep 11, 2023

Conversation

imjasonh
Copy link
Member

depguard is disabled because its new default config is to only allow stdlib deps (i.e., make you explicitly list each dep in your linter, for some reason) golangci/golangci-lint#3877

deadcode is disabled because it's unmaintained and warns when you use it.

The rest of the changes fix findings reported by newer versions of golangci-lint

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@imjasonh imjasonh merged commit d58b51e into ko-build:main Sep 11, 2023
20 of 21 checks passed
This was referenced Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants