-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support --platform=wasip1/wasm #1095
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1095 +/- ##
==========================================
- Coverage 49.23% 48.97% -0.26%
==========================================
Files 44 44
Lines 3650 3669 +19
==========================================
Hits 1797 1797
- Misses 1621 1639 +18
- Partials 232 233 +1
|
Spin
💥 Slight
(no output 😶 ) Wasmtime
🎉 |
This is really awesome work! |
Great!! This wasm image can run on Cloud run? |
I don't believe so, at least not yet. Luckily Cloud Run has great support for regular containers, so I don't think there's any real benefit to using wasm. |
This'd be pretty awesome for building wasm to use with Istio+Envoy! |
Yeah that sounds like a good use case. Do you have any docs about the current development process, that I could try to replicate with this change? |
This is how I've built WASM for use with Envoy for putting together an Envoy-compatible WASM public, I've used this package Let me know if I can help in any way not as useful but for C++ https://github.com/istio-ecosystem/wasm-extensions |
Signed-off-by: Jason Hall <[email protected]>
This Pull Request is stale because it has been open for 90 days with |
@imjasonh, thank you for the efforts so far. Is there any plan to eventually get this PR merged? Cheers |
In order to use this, you need:
When run this way, instead of producing
/ko-app/test
, it produces/ko-app/test.wasm
on top of an empty base image.You can run this image with:
Or, all together in one big blob:
Known issues:
go version -m test.wasm
doesn't work, so the SBOM is empty--platform=linux/amd64,wasip1/wasm
doesn't work, and it's unclear if anything could run it anyway