Set MSRV to 1.76 #871
Merged
Set MSRV to 1.76 #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
added
the
breaking change
Urhengulas
force-pushed
the
msrv
branch
3 times, most recently
from
062f2af
to
b84ac7e
Compare
Urhengulas
force-pushed
the
msrv
branch
3 times, most recently
from
39f299f
to
b64bd19
Compare
Hoverbear
reviewed
Oct 10, 2024
| "panic_info", | ||
| ]; | ||
| const NIGHTLY_SNAPSHOT_TESTS: &[&str] = &["alloc"]; | ||
| const POST_MSRV_SNAPSHOT_TESTS: &[&str] = &["net"]; |
There was a problem hiding this comment.
It's unclear to me what "post msrv snapshot tests" are. If we raise the msrv should this change?
There was a problem hiding this comment.
Yes. We have three brackets of tests
- tests that work on the msrv, stable and nightly
- tests that work on stable and nightly
- tests that work on nightly only
Regarding 2: The default defmt features support the msrv, but some of the optional features require a newer version, e.g. ip_in_core. These tests are the ones in POST_MSRV_TESTS. Maybe OPTIONAL_FEATURE_TESTS is better?
Regarding 3: These tests use unstable features.
There was a problem hiding this comment.
So POST_MSRV means "any version above our MSRV"? If so, a little comment would be really nice:
// Tests which run on all Rustc versions later than our MSRV
const POST_MSRV_SNAPSHOT_TESTS: &[&str] = &["net"];There was a problem hiding this comment.
Well it's not all versions. It's some version in MSRV..=STABLE.
This was referenced Oct 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents and tests Rust 1.76 as our MSRV. This is the version Ferrocene 24.05 is based on. Before we only guaranteed to support the latest stable.
I tried to store the MSRV in an env variable in the workflow file, but unfortunately env variables are not available in the strategy matrix, so it has to be repeated.