Skip to content

Commit

Permalink
Use dataplane-trust instead of internal-encryption (#14301)
Browse files Browse the repository at this point in the history
  • Loading branch information
nak3 authored Aug 29, 2023
1 parent ae86b1d commit 09a8095
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/activator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func main() {
}

// Enable TLS against queue-proxy when internal-encryption is enabled.
tlsEnabled := networkConfig.InternalEncryption
tlsEnabled := networkConfig.InternalTLSEnabled()

var certCache *certificate.CertCache

Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/revision/resources/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func makePodSpec(rev *v1.Revision, cfg *config.Config) (*corev1.PodSpec, error)
extraVolumes = append(extraVolumes, *tokenVolume)
}

if cfg.Network.InternalEncryption {
if cfg.Network.InternalTLSEnabled() {
queueContainer.VolumeMounts = append(queueContainer.VolumeMounts, varCertVolumeMount)
extraVolumes = append(extraVolumes, certVolume(networking.ServingCertName))
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/revision/revision.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, rev *v1.Revision) pkgrec
}

// Deploy certificate when internal-encryption is enabled.
if config.FromContext(ctx).Network.InternalEncryption {
if config.FromContext(ctx).Network.InternalTLSEnabled() {
if err := c.reconcileSecret(ctx, rev); err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ function install() {

if (( ENABLE_TLS )); then
echo "Patch to config-network to enable internal encryption"
toggle_feature internal-encryption true config-network
toggle_feature dataplane-trust minimal config-network
if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]]; then
echo "Point Kourier local gateway to custom server certificates"
toggle_feature cluster-cert-secret server-certs config-kourier
Expand Down

0 comments on commit 09a8095

Please sign in to comment.