Skip to content

Commit

Permalink
Drop special logic for kubelet probe header for istio (#950)
Browse files Browse the repository at this point in the history
* drop special logic for kubelet probe header for istio

* fix tests

* add header back

* address feedback
  • Loading branch information
izabelacg authored Mar 26, 2024
1 parent 1aa1ec2 commit 419ebf9
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions pkg/http/header/header.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,14 @@ const (
// at the Queue proxy level back to be a host header.
OriginalHostKey = "K-Original-Host"

// KubeletProbeKey is the name of the header supplied by kubelet
// probes. Istio with mTLS rewrites probes, but their probes pass a
// different user-agent. So we augment the probes with this header.
// KubeletProbeKey is the name of the header supplied by kubelet probes.
// Prior to this deprecation, Istio with mTLS rewrote probes and their probes passed a
// different user-agent. Therefore, this header was added to augment the probes.
//
// Deprecated: this custom request header is no longer necessary since Istio now propagates the
// original request header `User-Agent` sent by the kubelet (e.g., User-Agent: kube-probe/1.29).
// For updated usage, please utilize knative.dev/networking/pkg/http/header.UserAgentKey and
// knative.dev/networking/pkg/http/header.KubeProbeUAPrefix
KubeletProbeKey = "K-Kubelet-Probe"

// RouteTagKey is the name of the header entry which has a tag name as value.
Expand Down

0 comments on commit 419ebf9

Please sign in to comment.