Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python 3.11 for peribolos check #1621

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −1
Open

Use python 3.11 for peribolos check #1621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cd516a
Use python 3.11
dsimansk Oct 10, 2024
42c1ce2
Force periblox action run
dsimansk Oct 10, 2024
80d39f4
Fix formatting
dsimansk Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/peribolos-schema-validate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ jobs:
with:
fetch-depth: 0
lfs: true
- run: pip install strictyaml --break-system-packages
- uses: actions/setup-python@v5
with:
python-version: "3.11"
- run: pip install strictyaml
Comment on lines -32 to +35
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we can go with --break-system-packages or pin Python to a version that works without the flag. I don't know if there are any drawbacks with --break-system-packages, but it's one liner in a check we always can revisit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipx doesn't work for libraries:

➜  community git:(pr/pipx-fix) pipx install strictyaml

No apps associated with package strictyaml or its dependencies. If you are attempting to install a library, pipx should not be used. Consider using pip or a similar tool instead.

- name: Validate knative.yaml
run: python3 peribolos/validate-schema.py peribolos/knative.yaml
- name: Validate knative-extensions.yaml
Expand Down
1 change: 1 addition & 0 deletions peribolos/ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Thu Oct 10 15:10:16 CEST 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing an action run, should be removed in final version.

Loading