Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Adds buildah template creation step in README #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds buildah template creation step in README #99

wants to merge 1 commit into from

Conversation

navidshaikh
Copy link

This change adds step in README to create buildah build-template.

@vdemeester
Copy link
Member

/ok-to-test

vdemeester
vdemeester approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: navidshaikh, vdemeester
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: imjasonh

If they are not already assigned, you can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@navidshaikh
Copy link
Author

/retest

@navidshaikh
Adds buildah template creation step in README
fe8cadd 
This change adds step in README to create buildah build-template.

Update the patch with:
 - MD022 Headers should be surrounded by blank lines
 - MD031 Fenced code blocks should be surrounded by blank lines

For buildah/README.md, this got caught while linting the markdown files,
as part of CI.
@knative-prow-robot
Copy link

New changes are detected. LGTM label has been removed.

@knative-prow-robot
Copy link

@navidshaikh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-templates-build-tests fe8cadd link /test pull-knative-build-templates-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@navidshaikh
Copy link
Author

The new update to patch includes fixes for errors caught while linting the markdown files as part of CI.
Errors: ref logs, excerpts below

I0319 05:23:53.861] ---- Linting the markdown files ----
I0319 05:23:53.861] ------------------------------------
I0319 05:23:56.429] buildah/README.md:11: MD022 Headers should be surrounded by blank lines
I0319 05:23:56.430] buildah/README.md:12: MD031 Fenced code blocks should be surrounded by blank lines

@mattmoor mattmoor removed their request for review June 21, 2019 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navidshaikh @vdemeester @knative-prow-robot