Matplotlib #47
Merged
Matplotlib #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
reviewed
Dec 8, 2016
| file_data = QFileDialog.getSaveFileName( | ||
| self, | ||
| 'Choose a directory', | ||
| '', # use the last (or default) directory. It HAS to be str |
There was a problem hiding this comment.
I believe this was very useful comment, I think it should remain in place ;)
krassowski
reviewed
Dec 8, 2016
| '', extensions_string, | ||
| None, | ||
| QFileDialog.DontUseNativeDialog) | ||
| file_name = file_data[0] |
There was a problem hiding this comment.
What if user clicks cancel in the file dialog?
Traceback (most recent call last):
File "/home/krassowski/Desktop/KN_BiBS/dotplot/gui.py", line 113, in select_save_file_dialog
extension = extensions[file_data[1]]
KeyError:
krassowski
reviewed
Dec 8, 2016
| @@ -202,6 +221,7 @@ def create_canvas(self): | |||
| self.canvas = text_area | |||
|
|
|||
| self.canvas_box.addWidget(self.canvas) | |||
| self.canvas_box.addWidget(savebutton) | |||
There was a problem hiding this comment.
It's nice button. I would also add an entry in the menu. Just saying, not necessary.
|
The code is of good quality, added functions have concise docstrings. We need to add some tests to GUI later. There are some things which should be improved in the future, I listed them in comments. As the changes here are of high priority and overall quality is satisfying I will merge this straightaway. Many thanks @kinga322! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic axes labels with sequences names. Show sequence on the axis if it is short. Save plot to file. #34 #35