Add pid to Logging msg #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, although I don't use syslog logging right now. @sbchisholm, since you added syslog support, any comments? |
|
@kmsquire Might be a couple days before he gets around to this. @sbchisholm and I have been pulled away from the Julia world recently (unfortunately) and he's caught up with some other things right now (just a heads up) |
|
(and I'd provide any useful feedback if I had any, but I do not :) ) |
| @@ -78,7 +78,7 @@ function log(syslog::SysLog, level::LogLevel, color::Symbol, logger_name::Abstra | |||
| # syslog needs a timestamp in the form: YYYY-MM-DDTHH:MM:SS-TZ:TZ | |||
| t = time() | |||
| timestamp = string(Libc.strftime("%Y-%m-%dT%H:%M:%S",t), Libc.strftime("%z",t)[1:end-2], ":", Libc.strftime("%z",t)[end-1:end]) | |||
| logstring = string("<", (UInt16(syslog.facility) << 3) + UInt16(level), ">1 ", timestamp, " ", syslog.machine, " ", syslog.user, " - - - ", level, ":", logger_name,":", msg...) | |||
| logstring = string("<", (UInt16(syslog.facility) << 3) + UInt16(level), ">1 ", timestamp, " ", syslog.machine, " ", syslog.user, " - - - ", level, ":", logger_name,":",getpid(),":", msg...) | |||
There was a problem hiding this comment.
The string " - - - ", the first of these three placeholders is for the PROCID according to here: https://tools.ietf.org/html/rfc5424#section-6.5 (see example 2). Would it make more sense to use this?
|
@sbchisholm You just had to prove me wrong, didn't you :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42