fix: type guard and optional chaining

kleros · Sep 23, 2024 · 9adc56c · 9adc56c
1 parent 6ac81f5
commit 9adc56c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/packages/site/src/utils/snap.ts b/packages/site/src/utils/snap.ts
@@ -26,7 +26,7 @@ export const connectSnap = async (
   await window.ethereum.request({
     method: 'wallet_requestSnaps',
     params: {
-      'local:http://localhost:8080': {},
+      [snapId]: params,
     },
   });
 };

diff --git a/packages/snap/snap.manifest.json b/packages/snap/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/kleros/scout-snap.git"
   },
   "source": {
-    "shasum": "DlqfDuDIuE5TUyxf/9WDqcnL4mqh4SBnK2LUQ1IKkyg=",
+    "shasum": "ZPa+cVIYxWQtTVgnX38Z18BQZRsvF20Bx7OSdNBd6so=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/snap/src/index.ts b/packages/snap/src/index.ts
@@ -324,6 +324,7 @@ export const onTransaction: OnTransactionHandler = async ({
     ]),
   };
 };
+
 export const onSignature: OnSignatureHandler = async ({ signature }) => {
   const { signatureMethod, from, data } = signature;
   const insights: string[] = [];
@@ -332,13 +333,17 @@ export const onSignature: OnSignatureHandler = async ({ signature }) => {
     signatureMethod === 'eth_signTypedData_v3' ||
     signatureMethod === 'eth_signTypedData_v4'
   ) {
-    const verifyingContract = data.domain.verifyingContract;
-    const result = await getInsights(verifyingContract, from || 'NO_DOMAIN');
-
-    if (result.length > 0) {
-      insights.push(...result);
+    const verifyingContract = data?.domain?.verifyingContract;
+    if (verifyingContract) {
+      const result = await getInsights(verifyingContract, from || 'NO_DOMAIN');
+
+      if (result.length > 0) {
+        insights.push(...result);
+      } else {
+        insights.push('No insights available for this contract. Interact at your own risk.');
+      }
     } else {
-      insights.push('No insights available for this contract. Interact at your own risk.');
+      insights.push('No verifying contract found in the signature data.');
     }
   }