-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: no coupling between dispute kit and sortition (WIP) #1621
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →
|
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
Code Climate has analyzed commit c3d656c and detected 0 issues on this pull request. View more on Code Climate. |
PR-Codex overview
This PR updates the arbitration system by renaming the
draw
function todrawOne
for clarity and adds a newisJurorSolvent
function for checking juror solvency.Detailed summary
draw
function todrawOne
inIDisputeKit.sol
,KlerosCoreBase.sol
,KlerosCoreUniversity.sol
,DisputeKitClassic.sol
, andDisputeKitSybilResistant.sol
isJurorSolvent
function inKlerosCoreBase.sol
,KlerosCoreUniversity.sol
,DisputeKitClassic.sol
, andDisputeKitSybilResistant.sol