-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the dispute templates and data mappings #44
Conversation
Warning Rate limit exceeded@kemuru has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 52 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe updates in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for curate-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- contracts/deploy/00-curate-v2.ts (2 hunks)
Additional comments not posted (3)
contracts/deploy/00-curate-v2.ts (3)
22-37
: Dynamic Inclusion of Shared Properties in Registration TemplateThe registration template dynamically includes the
sharedTemplateProperties
. This is a good use of template literals for constructing complex JSON-like structures. Ensure that the inclusion does not introduce any syntax errors or misinterpretations of the JSON structure, especially since template literals are sensitive to whitespace and special characters.
43-55
: Dynamic Inclusion of Shared Properties in Removal TemplateSimilar to the registration template, the removal template effectively reuses the shared properties. This consistency in handling templates is beneficial for maintainability. Again, ensure that the JSON structure is correctly formed and that there are no runtime errors due to improper parsing.
153-154
: Enhanced Deployment Function with Template ParametersThe deployment function now includes
dataMappings
as part of the template parameters for both registration and removal processes. This is a significant enhancement as it allows dynamic data handling during the deployment. It is essential to ensure that these parameters are correctly utilized within the deployment logic to avoid any runtime issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Adapted from #33 (comment), using production subgraph endpoint.
PR-Codex overview
The PR enhances the Curate V2 deployment by adding shared template properties, updating registration and removal templates, and introducing data mappings for GraphQL and JSON.
Detailed summary
Summary by CodeRabbit