Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure sender nonce doesnt overflow u64 #1444

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 25, 2024

ensure the sender nonce is not MAX_U64 otherwise reject tx.


This change is Reviewable

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.7%. Comparing base (2b57e60) to head (bc5999e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/kakarot/errors.cairo 0.0% 23 Missing ⚠️
src/kakarot/interpreter.cairo 20.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1444     +/-   ##
=======================================
- Coverage   61.9%   61.7%   -0.3%     
=======================================
  Files         44      44             
  Lines       8169    8197     +28     
=======================================
- Hits        5062    5058      -4     
- Misses      3107    3139     +32     
Flag Coverage Δ
61.7% <3.5%> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat merged commit 58d82ec into main Sep 25, 2024
8 of 10 checks passed
@enitrat enitrat deleted the feat/ensure-nonce-max-u64 branch September 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants