Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove coinbase constructor arg #1438

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 24, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1391

What is the new behavior?

  • Removes the COINBASE constructor argument. If not set later, fees will be burnt.

This change is Reviewable

@enitrat enitrat force-pushed the feat/remove-coinbase-constructor-arg branch from 62a2017 to c2c24f7 Compare September 24, 2024 08:15
@enitrat enitrat changed the title remove coinbase constructor arg refactor: remove coinbase constructor arg Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.9%. Comparing base (87153b8) to head (d256fef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1438     +/-   ##
=======================================
- Coverage   62.8%   61.9%   -0.9%     
=======================================
  Files         49      44      -5     
  Lines       8386    8169    -217     
=======================================
- Hits        5270    5061    -209     
+ Misses      3116    3108      -8     
Flag Coverage Δ
61.9% <ø> (-0.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ClementWalter
ClementWalter previously approved these changes Sep 24, 2024
ClementWalter
ClementWalter previously approved these changes Sep 24, 2024
@enitrat enitrat force-pushed the feat/remove-coinbase-constructor-arg branch from e257a0e to 7cd417a Compare September 24, 2024 13:38
@ClementWalter ClementWalter merged commit f364214 into main Sep 24, 2024
9 of 10 checks passed
@ClementWalter ClementWalter deleted the feat/remove-coinbase-constructor-arg branch September 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: remove COINBASE from Kakarot constructor args
2 participants