Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run end2end tests on sn sepolia (no messaging) #1360

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Aug 22, 2024

Time spent on this PR: 0.5

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

After these minor fixes, I've been able to run Counter and PlainOpcodes tests.

For running the whole test suite, some more updates need to be done

  • get more ETH for the SN deployer account (like 100) or update values in tests
  • update sn messaging system fixture to use the real sn messaging contract on sepolia

What is the new behavior?


This change is Reviewable

@ClementWalter ClementWalter force-pushed the cw/deploy-sepolia branch 2 times, most recently from dda1f13 to 86613df Compare August 26, 2024 13:30
@ClementWalter ClementWalter force-pushed the cw/deploy-sepolia branch 3 times, most recently from 67bead5 to 1b98b66 Compare August 28, 2024 09:21
@ClementWalter ClementWalter marked this pull request as ready for review August 28, 2024 11:33
@ClementWalter
Copy link
Member Author

Note: I've not run the messaging tests so far, but I'd like to continue in other PR as with the rebase and without reploying I I can't debug the cairo error trace

Makefile Outdated Show resolved Hide resolved
@ClementWalter ClementWalter changed the title Run end2end tests on sn sepolia Run end2end tests on sn sepolia (no messaging) Aug 28, 2024
@ClementWalter ClementWalter self-assigned this Aug 28, 2024
@ClementWalter ClementWalter merged commit 2395950 into kkrt-labs:main Aug 28, 2024
6 checks passed
@ClementWalter ClementWalter deleted the cw/deploy-sepolia branch August 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants