Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove load word #988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lordshashank
Copy link

@lordshashank lordshashank commented Sep 28, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #906

What is the new behavior?

  • Removes the use of load_word in the codebase.
  • Uses from_be_bytes and from_be_bytes_partial instead for same functionality.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat
Copy link
Collaborator

enitrat commented Sep 28, 2024

can you clear the commit history to remove changes related to ceil32 ?

crates/evm/src/precompiles/ec_operations/ec_mul.cairo Outdated Show resolved Hide resolved
crates/evm/src/instructions/system_operations.cairo Outdated Show resolved Hide resolved
crates/evm/src/precompiles/ec_operations/ec_mul.cairo Outdated Show resolved Hide resolved
crates/evm/src/memory.cairo Outdated Show resolved Hide resolved
crates/evm/src/memory.cairo Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: prefer from_be_bytes to load_word
2 participants