Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace while loops with for #987

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor: replace while loops with for #987

wants to merge 5 commits into from

Conversation

fabrobles92
Copy link

@fabrobles92 fabrobles92 commented Sep 28, 2024 •
edited by enitrat
Loading

Replace while loops to use the new for loops

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

Resolves: #978

What is the new behavior?

  • Replacement of while loops with for loops

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

enitrat
enitrat reviewed Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! thank you so much!

crates/evm/src/instructions/duplication_operations.cairo Outdated Show resolved Hide resolved
crates/utils/src/helpers.cairo Outdated Show resolved Hide resolved
crates/utils/src/serialization.cairo Outdated Show resolved Hide resolved
crates/utils/src/traits/bytes.cairo Outdated Show resolved Hide resolved
crates/utils/src/traits/bytes.cairo Outdated Show resolved Hide resolved
@enitrat enitrat changed the title Feat/replace while loops refactor: replace while loops with for Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: replace iterations on collections with while to for loops
2 participants
@fabrobles92 @enitrat