Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: effective gas price #951

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: effective gas price #951

merged 2 commits into from
Sep 17, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 17, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • Fixes an issue where effective gas price was not using the effective tip but the max tip possible
  • Used the more logical Transaction function get_effective_gas_price instead of having a separate function
  • Now the checks and the computation are done in different places.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit d0cafae Sep 17, 2024
4 checks passed
@enitrat enitrat deleted the fix/effective-gas-price branch September 17, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants