-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement 0x38 - CODESIZE Opcode #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fn test_codesize() { | ||
// Given | ||
let bytecode: Span<u8> = array![1,2,3,4,5].span(); | ||
let mut ctx = setup_execution_context_with_bytecode(bytecode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi, here I think we can keep this setup function, as the bytecode will never be mutated (unlike return_data which might be, thus it makes sense to use a setter function)
rebase & good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #124
What is the new behavior?
Does this introduce a breaking change?