feat(evm): add push{i} opcodes #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
force-pushed
the
lucas/push-many
branch
from
e486d11
to
c02fe13
Compare
0xLucqs
force-pushed
the
lucas/push-many
branch
from
c02fe13
to
9df267c
Compare
enitrat
reviewed
Aug 28, 2023
0xLucqs
force-pushed
the
lucas/push-many
branch
from
ba72385
to
7066f65
Compare
enitrat
previously approved these changes
Aug 28, 2023
0xLucqs
force-pushed
the
lucas/push-many
branch
2 times, most recently
from
187986d
to
a3f8154
Compare
0xLucqs
force-pushed
the
lucas/push-many
branch
from
a3f8154
to
91533e1
Compare
enitrat
approved these changes
Aug 28, 2023
Quentash
pushed a commit
to Quentash/kakarot-ssj
that referenced
this pull request
Aug 29, 2023
* feat(evm): add push{i} opcodes
* refacto(evm): only 1 into in push
* fix(evm): actually return the result of the opcode
* impl suggestions
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* feat/chainidopcode * feat/chainidopcode * Update crates/evm/src/tests/test_instructions/test_block_information.cairo * docs: execution context (#176) * docs: execution context * chore: changelog * fix: typo * Update docs/general/model/execution_context.md Co-authored-by: Elias Tazartes <[email protected]> * Update docs/general/model/execution_context.md Co-authored-by: Elias Tazartes <[email protected]> * feat: add pc+=1 to diagram * chore: delete changelog --------- Co-authored-by: Elias Tazartes <[email protected]> * feat(evm): add basefee opcode (#191) * feat(evm): add basefee opcode * fix(evm): change basefee to gasprice * feat(evm): add gaslimit opcode (#192) * feat(evm): add gaslimit opcode * refacto(evm): implement suggestions * chore: fmt --------- Co-authored-by: Mathieu <[email protected]> Co-authored-by: msaug <[email protected]> * refacto(evm): improve split word by 2x (#196) * fix: gas reports (#217) * feat(evm): add push{i} opcodes (#195) * feat(evm): add push{i} opcodes * refacto(evm): only 1 into in push * fix(evm): actually return the result of the opcode * impl suggestions * refactor: simplify returns (#201) * refactor returns * make suggested changes in `decode_and_execute` function --------- Co-authored-by: Mathieu <[email protected]> Co-authored-by: Elias Tazartes <[email protected]> Co-authored-by: Lucas @ StarkWare <[email protected]> Co-authored-by: msaug <[email protected]> Co-authored-by: lambda-0x <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #194
What is the new behavior?
Does this introduce a breaking change?