Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gas-comparison PR bot #173

Merged
merged 2 commits into from
Aug 23, 2023
Merged

feat: add gas-comparison PR bot #173

merged 2 commits into from
Aug 23, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Aug 23, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Closes #163

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Added changes to CHANGELOG.md

  • Yes
  • No

Other information

@github-actions
Copy link

Snapshot Comparison Report:

No changes in gas consumption.

- name: Set up Scarb
uses: software-mansion/setup-scarb@v1
with:
scarb-version: "nightly-2023-08-12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought for later but chances are we'll forget to change all the places we mention scarb-version everytime we bump, is there a way to change it in one place & change it in all actions at once?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just cmd-f replace

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enitrat
Copy link
Collaborator Author

enitrat commented Aug 23, 2023

@Eikix please approve

@Eikix Eikix added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit b72d0d6 Aug 23, 2023
3 checks passed
@Eikix Eikix deleted the feat/gas-report-pr branch August 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: run gas snapshot compare python script in the CI and comment results in PR
2 participants