Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer refactoring: Constants #1396

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Indexer refactoring: Constants #1396

wants to merge 4 commits into from

Conversation

eugypalu
Copy link
Collaborator

@eugypalu eugypalu commented Sep 20, 2024 •
edited
Loading

Resolves: #1394

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

  • Typed the constants in the file constants.ts
  • Moved the constants config, DEFAULT_BLOCK_GAS_LIMIT and IGNORED_KEYS to constants.ts

Does this introduce a breaking change?

  • Yes
  • No

greged93
greged93 requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I want to wait the reactivation of hive before merging any unneeded changes.

ClementWalter
ClementWalter previously approved these changes Sep 23, 2024
View reviewed changes
tcoratger
tcoratger previously approved these changes Sep 23, 2024
View reviewed changes
@greged93
Copy link
Collaborator

hey @eugypalu couple of conflicts here, can you fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 requested changes

@ClementWalter ClementWalter ClementWalter left review comments

@tcoratger tcoratger tcoratger left review comments

@Eikix Eikix Awaiting requested review from Eikix Eikix is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indexer refactoring: Constants
4 participants
@eugypalu @greged93 @ClementWalter @tcoratger