Indexer refactoring: Consolidate tests and centralize type definitions #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugypalu
requested review from
ClementWalter,
Eikix and
greged93
as code owners
eugypalu
changed the title
ClementWalter
previously approved these changes
Sep 23, 2024
tcoratger
previously approved these changes
Sep 23, 2024
eugypalu
dismissed stale reviews from tcoratger and ClementWalter
via
a02ed2e
eugypalu
force-pushed
the
indexer_move_tests
branch
3 times, most recently
from
16ce77a
to
fa645f0
Compare
|
@eugypalu if you can rebase this we can merge! |
eugypalu
force-pushed
the
indexer_move_tests
branch
from
fa645f0
to
b4a7de6
Compare
eugypalu
force-pushed
the
indexer_move_tests
branch
from
b4a7de6
to
93bed53
Compare
greged93
force-pushed
the
indexer_move_tests
branch
from
93bed53
to
52bcdeb
Compare
greged93
approved these changes
Oct 21, 2024
greged93
force-pushed
the
indexer_move_tests
branch
from
52bcdeb
to
12a945e
Compare
greged93
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1392
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?