Fixed TestBindPFlagsStringSlice()

Replaced Visit() by VisitAll(), so that the Changed attribute of the updated flag is correctly set.
kklinan · Nov 7, 2018 · 69647fb · 69647fb
1 parent cc7e906
commit 69647fb
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/viper_test.go b/viper_test.go
@@ -630,11 +630,9 @@ func TestBindPFlagsStringSlice(t *testing.T) {
 
 			flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)
 			flagSet.StringSlice("stringslice", testValue.Expected, "test")
-			flagSet.Visit(func(f *pflag.Flag) {
-				if len(testValue.Value) > 0 {
-					f.Value.Set(testValue.Value)
-					f.Changed = changed
-				}
+			flagSet.VisitAll(func(f *pflag.Flag) {
+				f.Value.Set(testValue.Value)
+				f.Changed = changed
 			})
 
 			err := v.BindPFlags(flagSet)