Skip to content

Commit

Permalink
Refactor writable warm feature flag to include tiering (opensearch-pr…
Browse files Browse the repository at this point in the history
…oject#13799)

Signed-off-by: Neetika Singhal <[email protected]>
Signed-off-by: kkewwei <[email protected]>
  • Loading branch information
neetikasinghal authored and kkewwei committed Jul 24, 2024
1 parent 65c7283 commit afdcd3e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ protected FeatureFlagSettings(
FeatureFlags.IDENTITY_SETTING,
FeatureFlags.TELEMETRY_SETTING,
FeatureFlags.DATETIME_FORMATTER_CACHING_SETTING,
FeatureFlags.WRITEABLE_REMOTE_INDEX_SETTING,
FeatureFlags.PLUGGABLE_CACHE_SETTING,
FeatureFlags.REMOTE_STORE_MIGRATION_EXPERIMENTAL_SETTING
FeatureFlags.TIERED_REMOTE_INDEX_SETTING,
FeatureFlags.REMOTE_STORE_MIGRATION_EXPERIMENTAL_SETTING,
FeatureFlags.PLUGGABLE_CACHE_SETTING
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ public class FeatureFlags {
public static final String DATETIME_FORMATTER_CACHING = "opensearch.experimental.optimization.datetime_formatter_caching.enabled";

/**
* Gates the functionality of writeable remote index
* Gates the functionality of remote index having the capability to move across different tiers
* Once the feature is ready for release, this feature flag can be removed.
*/
public static final String WRITEABLE_REMOTE_INDEX = "opensearch.experimental.feature.writeable_remote_index.enabled";
public static final String TIERED_REMOTE_INDEX = "opensearch.experimental.feature.tiered_remote_index.enabled";

/**
* Gates the functionality of pluggable cache.
Expand All @@ -85,11 +85,7 @@ public class FeatureFlags {
Property.NodeScope
);

public static final Setting<Boolean> WRITEABLE_REMOTE_INDEX_SETTING = Setting.boolSetting(
WRITEABLE_REMOTE_INDEX,
false,
Property.NodeScope
);
public static final Setting<Boolean> TIERED_REMOTE_INDEX_SETTING = Setting.boolSetting(TIERED_REMOTE_INDEX, false, Property.NodeScope);

public static final Setting<Boolean> PLUGGABLE_CACHE_SETTING = Setting.boolSetting(PLUGGABLE_CACHE, false, Property.NodeScope);

Expand All @@ -99,7 +95,7 @@ public class FeatureFlags {
IDENTITY_SETTING,
TELEMETRY_SETTING,
DATETIME_FORMATTER_CACHING_SETTING,
WRITEABLE_REMOTE_INDEX_SETTING,
TIERED_REMOTE_INDEX_SETTING,
PLUGGABLE_CACHE_SETTING
);
/**
Expand Down

0 comments on commit afdcd3e

Please sign in to comment.