Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to macos-latest GitHub runners #1025

Closed
wants to merge 1 commit into from

Conversation

BPerlakiH
Copy link
Collaborator

In an attempt to try to fix the macOS build issues from: #1022

Switching to macOS-latest GitHub runners.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.97%. Comparing base (7644188) to head (aa3a8de).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   37.97%   37.97%           
=======================================
  Files         119      119           
  Lines        6952     6952           
=======================================
  Hits         2640     2640           
  Misses       4312     4312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgaudin
Copy link
Member

rgaudin commented Nov 9, 2024

We dont want to ever rely on latest, as it's a moving target. ATM macos-latest is macos-14 so please use that.

@kelson42
Copy link
Contributor

kelson42 commented Nov 9, 2024

We dont want to ever rely on latest, as it's a moving target. ATM macos-latest is macos-14 so please use that.

Indeed, see README.md. The only thing we can do is adding the most recent in the CI.

In addition, we try to avoid moving dependencoes, so never use "latest" to choose an OS.

@BPerlakiH
Copy link
Collaborator Author

Well, I have tried with the latest to see if it helps, but there's no difference really. The CI is failing the same way after adding Apple Pay, see here: #1026.

For this reason, I am closing these 2 PRs, as they are not helping at the moment.

@BPerlakiH BPerlakiH closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants