Code cleanup (#233)

kiwiproject · Sep 1, 2024 · 27b535f · 27b535f
1 parent def2ed0
commit 27b535f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/main/java/org/kiwiproject/retry/AttemptTimeLimiters.java b/src/main/java/org/kiwiproject/retry/AttemptTimeLimiters.java
@@ -65,7 +65,6 @@ public <T> T call(Callable<T> callable) throws Exception {
     }
 
     // Suppress API warnings about TimeLimiter in Guava which has been there since version 1.0
-    @SuppressWarnings("UnstableApiUsage")
     @Immutable
     private static final class FixedAttemptTimeLimit implements AttemptTimeLimiter {
 

diff --git a/src/test/java/org/kiwiproject/retry/AttemptTest.java b/src/test/java/org/kiwiproject/retry/AttemptTest.java
@@ -35,7 +35,7 @@ void shouldCreateWithResult() {
             () -> assertThat(attempt.hasResult()).isTrue(),
             () -> assertThat(attempt.hasException()).isFalse(),
             () -> assertThat(attempt.getResult()).isEqualTo(result),
-            () -> assertThatIllegalStateException().isThrownBy(() -> attempt.getException()),
+            () -> assertThatIllegalStateException().isThrownBy(attempt::getException),
             () -> assertThat(attempt.getAttemptNumber()).isEqualTo(attemptNumber),
             () -> assertThat(attempt.getDelaySinceFirstAttempt()).isEqualTo(delaySinceFirstAttempt)
         );
@@ -49,7 +49,7 @@ void shouldAllowNullResult() {
             () -> assertThat(attempt.hasResult()).isTrue(),
             () -> assertThat(attempt.hasException()).isFalse(),
             () -> assertThat(attempt.getResult()).isNull(),
-            () -> assertThatIllegalStateException().isThrownBy(() -> attempt.getException()),
+            () -> assertThatIllegalStateException().isThrownBy(attempt::getException),
             () -> assertThat(attempt.getAttemptNumber()).isEqualTo(attemptNumber),
             () -> assertThat(attempt.getDelaySinceFirstAttempt()).isEqualTo(delaySinceFirstAttempt)
         );
@@ -63,7 +63,7 @@ void shouldCreateWithException() {
         assertAll(
             () -> assertThat(attempt.hasResult()).isFalse(),
             () -> assertThat(attempt.hasException()).isTrue(),
-            () -> assertThatIllegalStateException().isThrownBy(() -> attempt.getResult()),
+            () -> assertThatIllegalStateException().isThrownBy(attempt::getResult),
             () -> assertThat(attempt.getException()).isSameAs(exception),
             () -> assertThat(attempt.getAttemptNumber()).isEqualTo(attemptNumber),
             () -> assertThat(attempt.getDelaySinceFirstAttempt()).isEqualTo(delaySinceFirstAttempt)

diff --git a/src/test/java/org/kiwiproject/retry/RetryerBuilderTest.java b/src/test/java/org/kiwiproject/retry/RetryerBuilderTest.java
@@ -521,7 +521,7 @@ private static Callable<Boolean> callableCountingDownAlwaysNull(final CountDownL
 
     private static Callable<Boolean> callableReturningNullUntil5Attempts() {
         return new Callable<>() {
-            AtomicInteger count = new AtomicInteger();
+            final AtomicInteger count = new AtomicInteger();
 
             @Override
             public Boolean call() {
@@ -543,7 +543,7 @@ private static Callable<Boolean> callableThrowingIOExceptionUntil5Attempts() {
 
     private static <E extends Exception> Callable<Boolean> callableThrowingExceptionUntil5Attempts(E e) {
         return new Callable<>() {
-            AtomicInteger count = new AtomicInteger();
+            final AtomicInteger count = new AtomicInteger();
 
             @Override
             public Boolean call() throws E {
@@ -557,7 +557,7 @@ public Boolean call() throws E {
 
     private static Callable<Boolean> callableThrowingOrReturningNullUntil5Attempts() {
         return new Callable<>() {
-            AtomicInteger counter = new AtomicInteger();
+            final AtomicInteger counter = new AtomicInteger();
 
             @Override
             public Boolean call() throws IOException {