Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snakeyaml from 1.33 to 2.0 #584

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2023

Bumps snakeyaml from 1.33 to 2.0.

Commits
  • c98ffba issue 561: add negative test case
  • e2ca740 Use Maven wrapper on github
  • 49d91a1 Fix target for github
  • 19e331d Disable toolchain for github
  • 42c7812 Cobertura plugin does not work
  • 03c82b5 Rename GlobalTagRejectionTest to be run by Maven
  • 6e8cd89 Remove cobertura
  • d9b0f48 Improve Javadoc
  • 519791a Run install and site goals under docker
  • 82f33d2 Merge branch 'master' into add-module-info
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Dependency updates java Pull requests that update Java code labels Feb 28, 2023
@sleberknight
Copy link
Member

Before merging this we need to understand why they bumped the major version. From a quick glance at the release notes I didn't see any mention of breaking changes.

@sleberknight
Copy link
Member

There are breaking changes to the public APIs even though that is not obvious from the commits list. But they are listed here: https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes

So before merging this, it will need to be regression tested. Even if we don't use any if the removed or changed public APIs in kiwi, Dropwizard uses this for parsing configuration, indirectly because dropwizard-configuation depends on jackson-dataformat-yaml which in turn depends on snakeyaml. So, updating could potentially break Dropwizard, Jackson, etc.

The latest (as of this writing on 3/6/2023) version of jackson-dataformat-yaml is 2.14.2, which uses snakeyaml version 1.3.3. So probably need to wait and see when Jackson updates, and then test it with Dropwizard.

For now, marking as DRAFT.

@sleberknight sleberknight marked this pull request as draft March 6, 2023 16:16
@sleberknight
Copy link
Member

Jackson has updated this into their baseline for their 2.15 release (which is not released at present).

Here is the PR - FasterXML/jackson-dataformats-text#390

Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.33 to 2.0.
- [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.0..snakeyaml-1.33)

---
updated-dependencies:
- dependency-name: org.yaml:snakeyaml
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.yaml-snakeyaml-2.0 branch from 701913c to 24bdc2c Compare March 23, 2023 21:11
@sleberknight
Copy link
Member

Jackson 2.15.0 has now been released, so we should test updating both Jackson and Snakeyaml at the same time, across all our repositories, to feel confident things will be fine if we upgrade them.

@sleberknight sleberknight marked this pull request as ready for review June 29, 2023 20:20
@sleberknight sleberknight merged commit 5635af1 into master Jun 29, 2023
@sleberknight sleberknight deleted the dependabot/maven/org.yaml-snakeyaml-2.0 branch June 29, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants