feat: support CLIENTTAGDENY #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for clients which want to do graceful degradations of client tags features such as typing, reacts, replies, etc. See https://ircv3.net/specs/extensions/message-tags#rpl_isupport-tokens for specification.
RaitoBezarius
force-pushed
the
clienttagdeny
branch
from
29d49a6
to
117580e
Compare
|
hm, this works as the bare minimum, but then again you force all callers to re-implement the "can I use this tag or not" logic... Might be worth to add a method or such that can answer this for you no? |
I actually have this code somewhere, I can push it if you want :). |
This introduces a `MessageTags.parseDenylist` which parses the value of `CLIENTTAGDENY=<value>` string into a structure containing everything you need to perform O(#allowed tags) or O(#denied tags) check for whether a tag is allowed or not. Then, a `MessageTags.isBlocked` function can be used to leverage that structure to perform this check.
|
@brunnre8 This is now pushed in a second commit. |
RaitoBezarius
changed the title
|
Replaced with #368 Thanks for the contribution @RaitoBezarius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for clients which want to do graceful degradations of client tags features such as typing, reacts, replies, etc.
See https://ircv3.net/specs/extensions/message-tags#rpl_isupport-tokens for specification.