Added lz4 #3071
Open
Added lz4 #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Oct 12, 2024
| env = self.get_recipe_env(arch) | ||
| build_dir = self.get_build_dir(arch.arch) | ||
| lib_dir = self.ctx.get_libs_dir(arch.arch) | ||
| include_dir = join(self.ctx.get_python_install_dir(), 'include', 'lz4') |
There was a problem hiding this comment.
CI is failing with:
Traceback (most recent call last):
File "/home/user/app/testapps/on_device_unit_tests/setup.py", line 106, in <module>
setup(
File "/home/user/app/venv/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.10/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.10/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.10/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/user/app/pythonforandroid/bdistapk.py", line 82, in run
main()
File "/home/user/app/pythonforandroid/entrypoints.py", line 18, in main
ToolchainCL()
File "/home/user/app/pythonforandroid/toolchain.py", line 677, in __init__
getattr(self, command)(args)
File "/home/user/app/pythonforandroid/toolchain.py", line 104, in wrapper_func
build_dist_from_args(ctx, dist, args)
File "/home/user/app/pythonforandroid/toolchain.py", line 163, in build_dist_from_args
build_recipes(build_order, python_modules, ctx,
File "/home/user/app/pythonforandroid/build.py", line 504, in build_recipes
recipe.build_arch(arch)
File "/home/user/app/pythonforandroid/recipes/liblz4/__init__.py", line 21, in build_arch
include_dir = join(self.ctx.get_python_install_dir(), 'include', 'lz4')
TypeError: Context.get_python_install_dir() missing 1 required positional argument: 'arch'
There was a problem hiding this comment.
Thanks, did you have a chance to test the recipe on-device, is it working?
AndreMiras
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Build is failing with:
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'ArchAarch_64'
https://github.com/kivy/python-for-android/actions/runs/11309141983/job/31461258396?pr=3071
Ideally you should test the recipe builds locally before pushing and also check that it's running properly on device.
| env = self.get_recipe_env(arch) | ||
| build_dir = self.get_build_dir(arch.arch) | ||
| lib_dir = self.ctx.get_libs_dir(arch.arch) | ||
| include_dir = join(self.ctx.get_python_install_dir(arch), 'include', 'lz4') |
There was a problem hiding this comment.
You probably want get_python_install_dir(arch.arch) here
|
|
||
| class LibLZ4Recipe(Recipe): | ||
| name = 'liblz4' | ||
| version = '1.9.4' # Use the desired version |
There was a problem hiding this comment.
We can probably drop this comment
|
|
||
| class Lz4Recipe(CompiledComponentsPythonRecipe): | ||
| name = 'lz4' | ||
| version = '4.3.2' # Use the desired version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add recipe for lz4, can somebody check and help please ?