Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we support lower than <
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the version for Cython from requirements.txt in the root of the repo, if there's a different version that should be locked to such as the latest build from v0.29 (0.29.36) that would make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On CI pipeline we use
Cython==0.29.33
,requirements.txt
haveCython==0.29.17
, onsetup.cfg
is unpinned, and onhostpython_prerequisites
is also unpinned.@jswillard what about pinning
0.29.36
everywhere? (for now, see: kivy/buildozer#1637 for full story)CI fails on this PR as
numpy
complains about the following:RuntimeError: Building NumPy requires Cython >= 0.29.30