Improve Buildozer's venv handling. #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rather than call a subprocess to run venv, use the built-in venv library. * Rather than check if an attribute exists, define it in __init__ and see if it has changed. * self.venv contained a folder name, but the folder name didn't need to be stored after the method returned. A boolean was all that was required. Also, some trivial clean ups thrown in: * Comment improvements. * Copy command didn't need to be logged; buildops will do that. * Directory's existence doesn't need to be checked; buildops will do that.
misl6
reviewed
Sep 10, 2023
Co-authored-by: Mirko Galimberti <[email protected]>
|
Good idea. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__()and see if it has changed.self.venvcontained a directory path, but the folder name didn't need to be stored after the method returned. A Boolean was all that was required.Also, some trivial clean ups thrown in: