Migrate to use Buildop's rmtree, file_copy, file_copytree and rename #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a bigger refactor to reduce the size and complexity of the Buildozer class. It adds no new functionality (apart from making logging more consistent) * Remove file_rename, file_copy and file_copytree from Buildozer. * Update all references to those Buildozer methods to refer to buildops equivalents. * Note: `file_rename` is now called rename as, in practice, it was also used to rename directories. * Updated all references to shutil.copyfile and shutil.rmtree to use the Buildops equivalents * Note this adds implicit debug logging, making them more consistent. * Updated all references to check_call() and check_output() that called the `rm` and `cp` shell commands. * Note this adds implicit debug logging, making them more consistent, and improves performance. * Updated mock in test. Cheekily, also removed some obsolete references to Python 2 (only) standard libraries to make my IDE stop warning me about them while I edited the file.
misl6
requested changes
Aug 25, 2023
| @@ -476,23 +476,6 @@ def file_matches(self, patterns): | |||
| def file_exists(self, *args): | |||
| return exists(join(*args)) | |||
|
|
|||
| def file_rename(self, source, target, cwd=None): | |||
There was a problem hiding this comment.
Seems we still have a reference to file_rename here:
buildozer/buildozer/targets/ios.py
Line 313 in b1f0e61
Julian-O
force-pushed
the
buildopsrenamecopy
branch
from
bd23368
to
7938754
Compare
|
Good spot. I do remember seeing the log message directly above it ('Moving IPA to bin...' sounds like it is throwing away some beer) so I don't know how I missed this one. Fixed. [I also accidentally gave a sneak preview of the next PR by committing in the wrong branch. I've undone that too.] |
😂 |
misl6
added a commit
to misl6/buildozer
that referenced
this pull request
Aug 27, 2023
misl6
added a commit
that referenced
this pull request
Aug 27, 2023
aorizondo
pushed a commit
to aorizondo/buildozer
that referenced
this pull request
Aug 28, 2023
…ivy#1669) * Migrate to use Buildop's rmtree, file_copy, file_copytree and rename This is part of a bigger refactor to reduce the size and complexity of the Buildozer class. It adds no new functionality (apart from making logging more consistent) * Remove file_rename, file_copy and file_copytree from Buildozer. * Update all references to those Buildozer methods to refer to buildops equivalents. * Note: `file_rename` is now called rename as, in practice, it was also used to rename directories. * Updated all references to shutil.copyfile and shutil.rmtree to use the Buildops equivalents * Note this adds implicit debug logging, making them more consistent. * Updated all references to check_call() and check_output() that called the `rm` and `cp` shell commands. * Note this adds implicit debug logging, making them more consistent, and improves performance. * Updated mock in test. Cheekily, also removed some obsolete references to Python 2 (only) standard libraries to make my IDE stop warning me about them while I edited the file. * Fixed missed file_rename reference in IOS
aorizondo
pushed a commit
to aorizondo/buildozer
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a bigger refactor to reduce the size and complexity of the Buildozer class. It adds no new functionality (apart from making logging more consistent)
file_renameis now called rename as, in practice, it was also used to rename directories.rmandcpshell commands.Cheekily, also removed some obsolete references to Python 2 (only) standard libraries to make my IDE stop warning me about them while I edited the file.