Most realisations of ymlloader and some realisations of etcdloader #1
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Printemps417 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| **Additional context** | ||
|
|
||
| Add any other context about the problem here. | ||
| --- |
There was a problem hiding this comment.
如果只是 \n 被改成了 \r\n ，那就调整一下你们的 IDE 设置，这样没意义的修改会干扰 review 和后续的协作。
go.mod
Outdated
| @@ -0,0 +1,52 @@ | |||
| module github.com/Printemps417/optionloader | |||
There was a problem hiding this comment.
github.com/kitex-contrib/optionloader
| @@ -0,0 +1 @@ | |||
| package client | |||
There was a problem hiding this comment.
etcd 和 consul 的实现，可以分到独立的 PR 提交
| kitexclient "github.com/cloudwego/kitex/client" | ||
| ) | ||
|
|
||
| type clientTranslator func(FieldConfig interface{}) ([]kitexclient.Option, error) |
| } | ||
| func (loader *clientLoader) Load() error { | ||
| for field, translator := range loader.translators { | ||
| // 通过字段名获取字段值 |
| continue | ||
| } | ||
| loader.options = append(loader.options, opts...) | ||
| } |
There was a problem hiding this comment.
对于配置中没有注册 translator 的key，最好也打个日志，以便排查。
| } | ||
|
|
||
| // 实现 Loader 接口的 GetOptions 方法。 | ||
| func (l *clientLoader) GetOptions() ([]kitexclient.Option, error) { |
There was a problem hiding this comment.
如果 GetOptions 这么实现的话，就没必要返回 error 了。
我建议是在 Load 方法加载配置数据，GetOptions 完成翻译，期间如果出现错误，可以返回错误，这样调用方才能根据情况处理。
| return nil | ||
| } | ||
|
|
||
| // 实现 Loader 接口的 AddDefaultOptions 方法。 |
| func (l *clientLoader) DeregisterTranslator(fieldName string) error { | ||
| // 注销字段名到 client 选项的转换器 | ||
| delete(l.translators, fieldName) | ||
| return nil |
|
|
||
| // CircuitBreaker | ||
| type Circuitbreaker circuitbreak.CBConfig | ||
| type YMLConfig struct { |
|
ci挂了，可以调整下 |
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: