Improved file extension detection of output

kit-data-manager · Aug 24, 2023 · 78fae0b · 78fae0b
1 parent 7d1d847
commit 78fae0b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/edu/kit/datamanager/mappingservice/util/FileUtil.java b/src/main/java/edu/kit/datamanager/mappingservice/util/FileUtil.java
@@ -143,7 +143,7 @@ public static Path fixFileExtension(Path pathToFile) {
                 fin = new FileInputStream(pathToFile.toFile());
                 byte[] header = fin.readNBytes(FEW_KILO_BYTES_FOR_TIKA);
                 fin.close();
-                String newExtension = guessFileExtension(header);
+                String newExtension = guessFileExtension(pathToFile.getFileName().toString(), header);
                 if (newExtension != null) {
                     if (!pathToFile.toString().endsWith(newExtension)) {
                         renamedFile = Paths.get(pathToFile + newExtension);
@@ -243,10 +243,11 @@ public static String getExtensionForMimeType(String mimeType) {
     /**
      * Guess the extension of the file from the first bytes using Apache Tika
      *
+     * @param filename The name of the file to support mime type detection.
      * @param fewKilobytesOfFile First few kilobytes of the file.
      * @return Estimated extension. e.g. '.xml'
      */
-    private static String guessFileExtension(byte[] fewKilobytesOfFile) {
+    private static String guessFileExtension(String filename, byte[] fewKilobytesOfFile) {
         String returnValue = null;
         String headerAsString = new String(fewKilobytesOfFile, 0, Math.min(fewKilobytesOfFile.length, MAX_LENGTH_OF_HEADER));
         LOGGER.trace("Guess type for '{}'", headerAsString);
@@ -265,7 +266,7 @@ private static String guessFileExtension(byte[] fewKilobytesOfFile) {
             LOGGER.trace("Use tika library to estimate extension.");
             Tika tika = new Tika();
             String mimeType;
-            mimeType = tika.detect(fewKilobytesOfFile);
+            mimeType = tika.detect(fewKilobytesOfFile, filename);
             MimeTypes allTypes = MimeTypes.getDefaultMimeTypes();
             MimeType estimatedMimeType;
             try {