Get parameterized list of datapoints #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvanscott
requested changes
Jan 28, 2021
| * | ||
| * @return array | ||
| */ | ||
| public static function getNovaChartjsMaxDataSet($chartName = 'default', $sortBy = null, $limit = 0): array |
There was a problem hiding this comment.
What do you think about trying to make these calls a little more dynamic? Is there a way we could use __callStatic for these since they're almost identical code? Do you think that would be a good idea here or should we avoid that for reasons I'm not thinking about?
There was a problem hiding this comment.
@dvanscott These calls are mostly convenience methods for end users. These are not used anywhere in our code directly.
These are also supposed to act as a template for end users it they want to add more such methods for their own use. That was one of the reason I wanted to keep it more readable.
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Co-authored-by: David VanScott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min,max,averageandmediandatasets