Fix #22 - Better support for vendor based .php files. #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #22:
vendor
folder./vendor/{package}/{locale}/filename.php
locale
as the new "directory" name (N.B. renamedbundle[directory]
tobundle[locale]
)locale
from the filename.This will convert the following:
vendor/some-package/en-GB/filename.php
to this:I don't use the
.json
option, so not sure if this has the same problem with the vendor packages.I haven't written a new test case for this, but can do if it's required.
I'm not sure if this is classified as a breaking change, as it fixes something that wouldn't have been possible to access previously.
Any questions, just let me know.