-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix!: update behaviour for an empty string inside Table field (#630)
BREAKING CHANGE: The behavior for an empty string inside the Table field changed (#630 ) Release-As: 1.10.7 Co-authored-by: hung-nguyen <[email protected]>
- Loading branch information
1 parent
c2f43e5
commit 418ffdb
Showing
3 changed files
with
134 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
src/record/import/repositories/parsers/parseCsv/__tests__/subtable.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
import type { SubtableRow, FieldInSubtable } from "../subtable"; | ||
|
||
import { fieldInSubtableReader } from "../subtable"; | ||
import type { InSubtable } from "../../../../types/schema"; | ||
|
||
const fields: InSubtable[] = [ | ||
{ | ||
type: "SINGLE_LINE_TEXT", | ||
code: "Text_0", | ||
label: "Text", | ||
noLabel: false, | ||
required: false, | ||
minLength: "", | ||
maxLength: "", | ||
expression: "", | ||
hideExpression: false, | ||
unique: false, | ||
defaultValue: "", | ||
}, | ||
{ | ||
type: "NUMBER", | ||
code: "Number_0", | ||
label: "Number", | ||
noLabel: false, | ||
required: false, | ||
minValue: "", | ||
maxValue: "", | ||
digit: false, | ||
unique: false, | ||
defaultValue: "", | ||
displayScale: "", | ||
unit: "", | ||
unitPosition: "BEFORE", | ||
}, | ||
]; | ||
|
||
const patterns: Array<{ | ||
description: string; | ||
input: SubtableRow; | ||
expected: FieldInSubtable[]; | ||
}> = [ | ||
{ | ||
description: "all fields have valid value", | ||
input: { | ||
id: "", | ||
row: { | ||
"*": "*", | ||
Record_number: "", | ||
Table: "1", | ||
Text_0: "Text_0", | ||
Number_0: "10", | ||
}, | ||
fields, | ||
}, | ||
expected: [ | ||
{ code: "Text_0", value: "Text_0", type: "SINGLE_LINE_TEXT" }, | ||
{ code: "Number_0", value: "10", type: "NUMBER" }, | ||
], | ||
}, | ||
{ | ||
description: "empty field value", | ||
input: { | ||
id: "", | ||
row: { | ||
"*": "*", | ||
Record_number: "", | ||
Table: "1", | ||
Text_0: "", | ||
Number_0: "10", | ||
}, | ||
fields, | ||
}, | ||
expected: [ | ||
{ code: "Text_0", value: "", type: "SINGLE_LINE_TEXT" }, | ||
{ code: "Number_0", value: "10", type: "NUMBER" }, | ||
], | ||
}, | ||
{ | ||
description: "missing field value", | ||
input: { | ||
id: "", | ||
row: { | ||
"*": "*", | ||
Record_number: "", | ||
Table: "1", | ||
Number_0: "10", | ||
}, | ||
fields, | ||
}, | ||
expected: [{ code: "Number_0", value: "10", type: "NUMBER" }], | ||
}, | ||
]; | ||
|
||
describe("fieldInSubtableReader", () => { | ||
it.each(patterns)("$description", ({ input, expected }) => { | ||
expect(Array.from(fieldInSubtableReader(input))).toStrictEqual(expected); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters