Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Initial To-Do List Application #96

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PragatiBasnet29
Copy link

@PragatiBasnet29 PragatiBasnet29 commented Oct 27, 2024

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

_Its a todo app that lists the task and make check after completion and can delete also

_

Screenshot

_Screenshot 2024-10-26 101048

.._

Live Project Link

the app is not live feel free to do so

Copy link
Contributor

👋 @PragatiBasnet29 👋

We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon.

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, To-Do List application is well-structured. However, a few tweaks could improve both usability and code quality:

  • Please rename the PR to something more descriptive that reflects its purpose, rather than just "hello."
  • Error handling in the add_task function to cover edge cases, like preventing duplicate tasks or handling input validation.
  • Additionally, adding keyboard shortcuts for adding and deleting tasks could enhance accessibility.
    With these adjustments, it can become even more polished and user-friendly. Excited to see your updates!

@PragatiBasnet29 PragatiBasnet29 changed the title hello Create Initial To-Do List Application Oct 30, 2024
@PragatiBasnet29
Copy link
Author

Here's a revised response that acknowledges the improvements you've made and reflects a refined and organized project update:


Thank you for your feedback! I’ve implemented the suggestions to enhance the To-Do List application’s usability and code quality. Here’s an overview of the updates:

  • PR Renaming: Updated the PR title to be more descriptive, clearly reflecting the purpose of this update.
  • Enhanced Error Handling: The add_task function now includes robust error handling, preventing duplicate tasks and handling input validation for empty and whitespace-only entries, as well as optional task length limits.
  • Keyboard Shortcuts: Added keyboard shortcuts for easier accessibility: pressing "Enter" adds a new task, and pressing "Delete" removes completed tasks.

These changes aim to create a more polished, user-friendly experience, with streamlined functionality and improved code readability. Looking forward to any additional feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants