Feature/otel trials #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaur13
force-pushed
the
feature/otel-trials
branch
from
948d1e5
to
65ae8de
Compare
akaur13
force-pushed
the
feature/otel-trials
branch
from
65ae8de
to
ab21777
Compare
| let new_message = &message; | ||
| let headers = required_headers(new_message).expect("parsing headers failed"); | ||
| let message_deadline: DateTime<Utc> = DateTime::<Utc>::from_str(&headers[DEADLINE]).expect("String date parsing failed"); | ||
| #[instrument(skip_all, fields(correlationId))] |
There was a problem hiding this comment.
What does this fields(correlationId) do?
There was a problem hiding this comment.
ID to stitch the consumer of the delay scheduler to the delay process working. This field will be added as an attribute in the trace on which it can be filtered across different app traces
There was a problem hiding this comment.
When annotation processor will be handling this expression, where the value of correlationId will come from?
| global::set_text_map_propagator(TraceContextPropagator::new()); | ||
| opentelemetry_otlp::new_pipeline() | ||
| .tracing() | ||
| .with_exporter(opentelemetry_otlp::new_exporter().http().with_protocol(protocol).with_endpoint(trace_exporter)) |
There was a problem hiding this comment.
We are taking protocol as parameter but at the same time calling .http(). Is this intentional?
akaur13
commented
Oct 23, 2023
| OtlpCollector {} | ||
| } | ||
|
|
||
| pub fn http_collector_connect(&self, protocol: Protocol) -> Result<sdktrace::Tracer, TraceError> { |
There was a problem hiding this comment.
@fmarek-kindred this is a method which is calling the http protocol as per the input
fmarek-kindred
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing traces telemetry for Chronos using Otel collector with daemon set