Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 16 in CI #1306

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Xcode 16 in CI #1306

merged 5 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Configure CI to run on Xcode 16

    @justinseanmartin
    justinseanmartin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a6672dc View commit details
    Browse the repository at this point in the history

  2. Ensure that the UITextEffectsWindow also gets layer speed multipliers… 

    … applied

The UITextEffectsWindow directly uses a private initializer, bypassing the public initializer.
The `[UIWindow init]` implementation will call through to this private designated initializer,
so overriding both is unnecessary. I've added an assertion to the swizzle helpers to prevent
this from silently failing in the future if the private APIs change.
    @justinseanmartin
    justinseanmartin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    111c52d View commit details
    Browse the repository at this point in the history

  3. Improve detection of in progress animations 

    There were cases where we were not identifying animations that were still
in progress. For example, if I turn on the simulator slow animations setting,
we don't wait a sufficient amount of time for animations to complete. This
was consistently showing up when running -[TypingTests testEnteringTextIntoFirstResponder]`.

As this test was failing on Xcode 16 in CI, it seems like this change is
needed to get KIF working reliably.
    @justinseanmartin
    justinseanmartin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e263dac View commit details
    Browse the repository at this point in the history

  4. Set .25s min for animation stabilization wait time, regardless of lay… 

    …er speed

When animations are set to 100x speed, the text field popover control is
presented without animations. This causes issues in the call to waitForAnimations,
because the presentation still happens after some delay. This is a crude hack to
prevent significantly sped up animations from failing to tap on popovers.
    @justinseanmartin
    justinseanmartin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cbf90e4 View commit details
    Browse the repository at this point in the history

  5. Speed up many tests by decreasing longPress durations from 2s to 1s

    @justinseanmartin
    justinseanmartin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    25645e8 View commit details
    Browse the repository at this point in the history