Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve error message on mockStep failure #74

Merged
merged 4 commits into from
Feb 13, 2024
Merged

fix: Improve error message on mockStep failure #74

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
102fb83
Improve error message on mockStep failure
TWiStErRob Feb 12, 2024
5fcb2e8
Apply destructuring trick
TWiStErRob Feb 12, 2024
f41f8d9
Fix lint
TWiStErRob Feb 13, 2024
95d3301
Explicitly test error messages
TWiStErRob Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/step-mocker/step-mocker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
this.updateStep(workflow, jobId, stepIndex, mockStep);
}
} else {
throw new Error("Could not find step");
const { mockWith, ...stepQuery } = mockStep;

Check warning on line 46 in src/step-mocker/step-mocker.ts

View workflow job for this annotation

GitHub Actions / lint 

'mockWith' is assigned a value but never used. Allowed unused vars must match /^_/u
throw new Error(`Could not find step ${JSON.stringify(stepQuery)} in job ${jobId}\nin ${filePath}`);
}
}
stepsToAdd.forEach(s => this.addStep(workflow, s.jobId, s.stepIndex, s.mockStep));
Expand Down
Loading