Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for passing variables #68

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

im-sampm
Copy link
Contributor

@im-sampm im-sampm commented Jan 6, 2024

This change adds basic support for passing --vars to Act.

I chose to model the change on the env implementation rather than event for simplicity, but I feel like vars, env and input could probably be refactored to have a common implementation.

I haven't created test cases for this change.

@shubhbapna shubhbapna self-requested a review January 9, 2024 07:53
Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yes I did write the ArgumentMap class to reduce duplicate code between act options like env, matrix, platforms etc but it mainly focuses on having no duplicate code for the toActArguments method. I am open to considering better design options!

@shubhbapna shubhbapna changed the title Added support for passing variables feat: added support for passing variables Jan 9, 2024
@shubhbapna shubhbapna merged commit 74b85dc into kiegroup:main Jan 9, 2024
5 checks passed
@im-sampm
Copy link
Contributor Author

im-sampm commented Jan 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants